Skip to content

add single directive for monetary tab#1292

Merged
belwalshubham merged 1 commit intodevelopfrom
feat/single-directive
Jun 13, 2025
Merged

add single directive for monetary tab#1292
belwalshubham merged 1 commit intodevelopfrom
feat/single-directive

Conversation

@belwalshubham
Copy link
Copy Markdown
Collaborator

@belwalshubham belwalshubham commented Jun 13, 2025

Add Single Directive for monetary tab

Summary by CodeRabbit

  • Refactor
    • Updated template paths for monetary contribution tabs across multiple sections to use a unified location.
  • Chores
    • Removed duplicate and obsolete template files for monetary contribution tabs to streamline template management.

No changes to user-facing functionality or workflows.

@belwalshubham belwalshubham self-assigned this Jun 13, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates several service classes to reference shared template files for monetary contribution tabs by shortening their template paths. Redundant or directory-specific template files are deleted, consolidating the templates into a common location. No logic, permissions, or control flow are altered; only template paths and file organization are affected.

Changes

Files/Paths (Grouped) Change Summary
Civi/CollectionCampService.php, Civi/DroppingCenterService.php, Civi/GoonjActivitiesService.php,
Civi/InstitutionCollectionCampService.php, Civi/InstitutionDroppingCenterService.php, Civi/InstitutionGoonjActivitiesService.php
Updated template paths for monetary contribution tabs to reference shared templates, removing subdirectory paths.
templates/CRM/Goonjcustom/Tabs/CollectionCamp/MonetaryContributionForUrbanOps.tpl,
templates/CRM/Goonjcustom/Tabs/DroppingCenter/MonetaryContribution.tpl,
templates/CRM/Goonjcustom/Tabs/DroppingCenter/MonetaryContributionForUrbanOps.tpl,
templates/CRM/Goonjcustom/Tabs/GoonjActivities/MonetaryContribution.tpl,
templates/CRM/Goonjcustom/Tabs/GoonjActivities/MonetaryContributionForUrbanOps.tpl,
templates/CRM/Goonjcustom/Tabs/InstitutionCollectionCamp/MonetaryContribution.tpl,
templates/CRM/Goonjcustom/Tabs/InstitutionCollectionCamp/MonetaryContributionForUrbanOps.tpl,
templates/CRM/Goonjcustom/Tabs/InstitutionDroppingCenter/MonetaryContribution.tpl,
templates/CRM/Goonjcustom/Tabs/InstitutionDroppingCenter/MonetaryContributionForUrbanOps.tpl,
templates/CRM/Goonjcustom/Tabs/InstitutionGoonjActivities/MonetaryContribution.tpl,
templates/CRM/Goonjcustom/Tabs/InstitutionGoonjActivities/MonetaryContributionForUrbanOps.tpl
Deleted redundant template files for monetary contribution tabs, consolidating usage to shared templates.

Possibly related PRs

Suggested labels

status : ready for review

Suggested reviewers

  • tarunnjoshi

Poem

Templates march to a single tune,
No more lost in folder gloom!
Paths now short, the code is neat,
Redundant files admit defeat.
With tabs aligned and clutter gone,
The codebase sings a lighter song.
🎶🧹


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 785ce28 and 94f344a.

📒 Files selected for processing (17)
  • wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/DroppingCenterService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionGoonjActivitiesService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/CollectionCamp/MonetaryContributionForUrbanOps.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/DroppingCenter/MonetaryContribution.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/DroppingCenter/MonetaryContributionForUrbanOps.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/GoonjActivities/MonetaryContribution.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/GoonjActivities/MonetaryContributionForUrbanOps.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/InstitutionCollectionCamp/MonetaryContribution.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/InstitutionCollectionCamp/MonetaryContributionForUrbanOps.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/InstitutionDroppingCenter/MonetaryContribution.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/InstitutionDroppingCenter/MonetaryContributionForUrbanOps.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/InstitutionGoonjActivities/MonetaryContribution.tpl (0 hunks)
  • wp-content/civi-extensions/goonjcustom/templates/CRM/Goonjcustom/Tabs/InstitutionGoonjActivities/MonetaryContributionForUrbanOps.tpl (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@belwalshubham belwalshubham merged commit 5ed7173 into develop Jun 13, 2025
1 check was pending
@belwalshubham belwalshubham deleted the feat/single-directive branch June 13, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant