add check for preventing duplicate emails

[pokhiii]

Summary by CodeRabbit

• New Features

  • Enhanced email notification logic for collection camps to prevent duplicate notifications.
  • Updated conditions for sending feedback and completion emails based on new flags.

• Bug Fixes

  • Improved accuracy of email dispatch by ensuring emails are sent only if not previously sent.

[coderabbitai]

Walkthrough

The changes enhance the email notification logic within the civicrm_api3_goonjcustom_collection_camp_cron function. The updates ensure that feedback and completion emails are sent only if they have not been previously dispatched, utilizing new checks against specific fields. Upon successful email dispatch, these fields are updated to reflect that the emails have been sent. Additionally, the query for collection camps now includes these new email sent flags.

Changes

File Path	Change Summary
wp-content/civi-extensions/goonjcustom/api/v3/Goonjcustom/CollectionCampCron.php	Enhanced email notification logic to prevent duplicate emails by checking specific fields before sending. Updated fields to indicate emails have been sent. Expanded query to include new email sent flags.

Possibly related PRs

• Updated Mail Id for Collection Camp #300: This PR also modifies the civicrm_api3_goonjcustom_collection_camp_cron function, focusing on email sending logic, which is directly related to the enhancements made in the main PR regarding email notifications for collection camps.

Suggested labels

in review

Poem

🐰 In the fields where emails roam,
A check was placed to call them home.
No more duplicates in sight,
Just clear notifications, oh what a delight!
With flags now waving, bright and true,
Goonjcustom's logic shines anew! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

wp-content/civi-extensions/goonjcustom/api/v3/Goonjcustom/CollectionCampCron.php (1)

120-127: Consider adding error logging for failed email sends.

The implementation effectively prevents duplicate emails and updates the sent status after successful sending. To further improve the code, consider adding error logging for cases where email sending fails. This would help in troubleshooting and monitoring the email sending process.

Example:

if ($feedbackEmailSendResult) {
  // Existing code to update email sent status
} else {
  \Civi::log()->error("Failed to send feedback email for camp ID $collectionCampId");
}

Apply similar logging for the completion email sending process as well.

Also applies to: 152-159

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fcc319e and 801623e.

📒 Files selected for processing (1)

• wp-content/civi-extensions/goonjcustom/api/v3/Goonjcustom/CollectionCampCron.php (4 hunks)

🔇 Additional comments (6)

wp-content/civi-extensions/goonjcustom/api/v3/Goonjcustom/CollectionCampCron.php (6)

58-58: LGTM: New fields added to prevent duplicate emails.

The addition of 'Logistics_Coordination.Email_Sent' and 'Logistics_Coordination.Feedback_Email_Sent' fields in the addSelect method is appropriate. These fields will be used to check if emails have already been sent, which aligns with the PR objective of preventing duplicate emails.

---

73-74: LGTM: Variables added to track email sent status.

The introduction of $logisticEmailSent and $feedbackEmailSent variables is appropriate. These variables will be used to store the email sent status, which is crucial for preventing duplicate emails as per the PR objective.

---

112-112: LGTM: Condition added to prevent duplicate feedback emails.

The addition of !$feedbackEmailSent to the condition for sending feedback emails is correct. This ensures that feedback emails are only sent if they haven't been sent before, which directly addresses the PR objective of preventing duplicate emails.

---

120-127: LGTM: Feedback email sent status updated after successful sending.

The addition of code to update the 'Logistics_Coordination.Feedback_Email_Sent' field to 1 after successfully sending the feedback email is appropriate. This ensures that the email sent status is accurately recorded, preventing duplicate emails in future runs. The conditional update based on successful email sending is a good practice.

---

144-144: LGTM: Condition added to prevent duplicate completion emails.

The addition of !$logisticEmailSent to the condition for sending completion notification emails is correct. This ensures that completion emails are only sent if they haven't been sent before, which directly addresses the PR objective of preventing duplicate emails.

---

152-159: LGTM: Completion email sent status updated after successful sending.

The addition of code to update the 'Logistics_Coordination.Email_Sent' field to 1 after successfully sending the completion email is appropriate. This ensures that the email sent status is accurately recorded, preventing duplicate emails in future runs. The conditional update based on successful email sending is a good practice.