Skip to content

Add new tabs for urban ops to see only the contribution#471

Merged
tarunnjoshi merged 1 commit intodevelopfrom
add-monetary-contribution-tab
Nov 18, 2024
Merged

Add new tabs for urban ops to see only the contribution#471
tarunnjoshi merged 1 commit intodevelopfrom
add-monetary-contribution-tab

Conversation

@tarunnjoshi
Copy link
Copy Markdown
Member

@tarunnjoshi tarunnjoshi commented Nov 18, 2024

Add new tabs for urban ops to see only the contribution

Summary by CodeRabbit

  • New Features

    • Added a new tab for "Monetary Contribution for Urban Ops" in both the Collection Camp and Dropping Center services, allowing users with the appropriate permissions to access enhanced functionality related to monetary contributions.
  • Bug Fixes

    • Ensured that the new tabs adhere to existing permission checks, maintaining secure access for authorized users.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 18, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce new tab configurations for the CollectionCampService and DroppingCenterService classes. Each class now includes a new tab titled "Monetary Contribution for Urban Ops," which is integrated into their respective tabset methods. The new tabs include properties such as title, module, directive, template, and permissions, ensuring they are only accessible to users with the appropriate permissions. No existing methods or logic were altered, maintaining the overall structure and functionality of the services.

Changes

File Path Change Summary
wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php Added new tab configuration in collectionCampTabset method for monetaryContributionForUrbanOps.
wp-content/civi-extensions/goonjcustom/Civi/DroppingCenterService.php Introduced new tab configuration in droppingCenterTabset method for monetaryContributionForUrbanOps.

Possibly related PRs

  • Add Monetary Contribution Tabs #441: This PR adds a new tab for "Monetary Contribution" in the CollectionCampService, which is directly related to the new tab configuration for "Monetary Contribution for Urban Ops" introduced in the main PR.
  • Add ACL Monetory Contribution #470: This PR modifies the collectionCampTabset method to include role-based visibility for the "Monetary Contribution" tab, which aligns with the new tab added in the main PR, ensuring that it is displayed based on user permissions.

Suggested labels

status : ready for review

Suggested reviewers

  • pokhiii

🌟 In the code where tabs do play,
A new one shines, bright as day.
For urban ops, a contribution's call,
With permissions set, it welcomes all.
In services old, a fresh face appears,
Enhancing our tools, let’s give three cheers! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant