send dispatch email only if there is camp attended by id

[belwalshubham]

Code cleanups

Summary by CodeRabbit

• New Features

  • Updated logistics email sending logic to improve recipient targeting based on camp management and attendance.
  • Enhanced outcome email functionality to include a specific camp identifier for better link generation.

• Bug Fixes

  • Corrected conditions for sending logistics emails to ensure appropriate recipients receive notifications.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the sendLogisticsEmail and sendOutcomeEmail methods within the InstitutionCollectionCampService class. The conditional logic for sending logistics emails has been updated to refine which recipients receive the emails based on the camp's management and attendance status. Additionally, the sendOutcomeEmail method has been altered to include a new parameter for constructing the camp outcome form URL, ensuring the correct identifier is used.

Changes

File Path	Change Summary
wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php	- Updated sendLogisticsEmail method's conditional logic for email sending. - Modified sendOutcomeEmail method to include $campAttendedById parameter.

Possibly related PRs

• bug fixes and refactor #329: The sendLogisticsEmail method was added in this PR, which is directly related to the changes made in the sendLogisticsEmail method in the main PR.
• Collection Camp Authorisation Status #362: This PR modifies the sendLogisticsEmail method to include a check for the camp status, aligning with the changes in the main PR.
• Fix the condition for Camp outcome reminder #366: Updates to the processCampReminder method include a new parameter and refined logic for sending reminders, relevant to the overall email handling improvements.
• Reminder for outcome 2 emails will be sent #392: This PR modifies the processCampReminder method, focusing on the logic for sending reminders, which relates to the email sending logic in the main PR.
• Generate Institution collection camp title #475: Changes in this PR include updates to the CollectionCampService class, relevant to modifications in the sendOutcomeEmail method.
• Remove functionality that stops to send the receipt #500: This PR removes functionality related to email suppression, relevant to the overall email handling and notification logic.

Suggested labels

status : ready for review

Suggested reviewers

• tarunnjoshi
• nishant22029

🎉 In the code's dance, a twist we see,
Logistics emails now flow with glee.
With parameters set just right,
Camp outcomes shine, a joyful sight!
So let’s review, and give a cheer,
For clean code brings us all good cheer! 🎊

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[belwalshubham]

Minor changes , So merging this PR.