acl query for collection camp subtypes

[pokhiii]

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced event handling and email notification logic across multiple services.
  • Improved QR code generation for collection camps based on status changes.

• Bug Fixes

  • Refined checks for email dispatching and address management in various services.
  • Enhanced error logging for missing state or contact IDs.

• Documentation

  • Added comments for clarity in several methods to improve code readability.

• Refactor

  • Streamlined logic for managing state-related data and modularized event handling.

These updates aim to improve the overall functionality, maintainability, and user experience within the application.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant refactoring across multiple classes within the Civi namespace. Key changes include the removal of constants, updates to method logic for handling state fields and email notifications, and the introduction of new methods to enhance modularity and clarity. The handling of SQL clauses and event subscriptions has been improved, alongside better error logging and checks for email dispatching. Overall, the modifications aim to streamline functionality and improve maintainability throughout the services.

Changes

File Path	Change Summary
wp-content/civi-extensions/goonjcustom/Civi/CollectionBaseService.php	- Removed constant INTENT_CUSTOM_GROUP_NAME. - Refactored getStateFieldDbDetails for multiple state fields retrieval. - Added private method getStateGroupNameMapper. - Altered SQL clause construction in aclCollectionCamp.
wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php	- Removed import of CRM_Core_Action. - Updated getSubscribedEvents with new hooks. - Refined address-setting methods and streamlined chapter group assignment logic. - Enhanced status update methods and email notification logic.
wp-content/civi-extensions/goonjcustom/Civi/DroppingCenterService.php	- Added comments for clarity. - Updated permission checks in droppingCenterTabset. - Modified processDispatchEmail and sendDispatchEmail for better email handling.
wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php	- Added comments for clarity. - Updated logic in setActivitiesVolunteersAddress and other methods for better validation checks.
wp-content/civi-extensions/goonjcustom/Civi/InductionService.php	- Refined email notification logic in sendInductionRescheduleEmail and sendFollowUpEmails. - Improved clarity in sendInductionEmail method.
wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php	- Updated getSubscribedEvents with additional hooks. - Enhanced error logging in assignChapterGroupToIndividual. - Improved email notification handling in mailNotificationToMmt and sendLogisticsEmail.

Possibly related PRs

• Feat/dropping center dispatch email #266: Related to handling state fields and SQL clause generation in CollectionBaseService.
• add check for poster presence before trying to attach it #308: Focuses on email attachment handling in the same class.
• bug fixes and refactor #329: Relevant to handling collection camps and associated activities.
• Collection Camp Authorisation Status #362: Involves updating camp statuses and SQL clause handling.
• Update Email Content #411: Enhances address handling for collection camps.
• Add Cron to send Reschedule email volunteer induction status is not Visited #459: Aligns with reschedule email functionalities for induction activities.
• Update Contributor And Contribution Count #522: Related to updating contributor counts and handling collection camps.
• Initial Draft: Institution Dropping Center Implementation #528: Focuses on institution dropping centers and state options.
• Add setIndianStateOptions Hook for Dynamic State Options in CollectionBaseService #533: Directly related to dynamic state options for Eck_Collection_Camp.
• Add institution dropping center authorized email #538: Involves handling authorization emails and new fields.
• Fix the issue with urban ops on production #543: Enhances permission management across various tabs.

Suggested labels

status : ready for review

🐾 In the code's dance, changes take flight,
From fields to emails, all feels just right.
With logic refined and clarity bright,
A symphony of functions, a coder's delight!
So let’s celebrate this code's new height! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c71276f and d777721.

📒 Files selected for processing (6)

• wp-content/civi-extensions/goonjcustom/Civi/CollectionBaseService.php (4 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (0 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/DroppingCenterService.php (1 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php (1 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/InductionService.php (4 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.