Skip to content

Production Release - 19/Dec/2024 - Fixing ACL: Hide the custom group fixing acl#646

Merged
tarunnjoshi merged 1 commit intomainfrom
hide-the-custom-group-fixing-acl
Dec 19, 2024
Merged

Production Release - 19/Dec/2024 - Fixing ACL: Hide the custom group fixing acl#646
tarunnjoshi merged 1 commit intomainfrom
hide-the-custom-group-fixing-acl

Conversation

@tarunnjoshi
Copy link
Copy Markdown
Member

@tarunnjoshi tarunnjoshi commented Dec 19, 2024

Production Release - 19/Dec/2024 - Hide the custom group fixing acl

Summary by CodeRabbit

  • New Features

    • Enhanced display logic for induction schedule information, providing clear feedback based on status.
  • Bug Fixes

    • Commented out monetary contribution links in the user interface to prevent rendering.
  • Chores

    • Cleaned up tab configurations related to monetary contributions across various services, disabling them without deleting the code.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves modifications across multiple service classes and render files within the Goonj custom extension. The primary changes focus on removing or commenting out monetary contribution-related tab configurations in various service classes like CollectionBaseService, CollectionCampService, DroppingCenterService, and others. Additionally, the render.php files have been updated to modify the display of donation links and enhance induction schedule information handling.

Changes

File Change Summary
wp-content/civi-extensions/goonjcustom/Civi/CollectionBaseService.php Commented out mappings for specific entities in getStateGroupNameMapper() method
wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php Removed monetary contribution tab configurations from collectionCampTabset() method
wp-content/civi-extensions/goonjcustom/Civi/DroppingCenterService.php Commented out monetary contribution tabs in droppingCenterTabset() method
wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php Removed monetary contribution tab configurations from goonjActivitiesTabset() method
wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php Commented out monetary contribution tabs in institutionCollectionCampTabset() method
wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php Removed monetary contribution tab configurations
wp-content/plugins/goonj-blocks/build/render.php Enhanced induction schedule status handling and commented out monetary contribution links
wp-content/plugins/goonj-blocks/src/render.php Similar changes to build/render.php with improved induction schedule logic

Possibly related PRs

Suggested Labels

status : ready for review

Suggested Reviewers

  • nishant22029

Poem

🌟 Code refactoring, tabs fade away,
Monetary links take a brief holiday
Induction schedules now shine bright
With status updates, clear and tight
A digital dance of clean design! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da61a10 and 462f2fc.

📒 Files selected for processing (8)
  • wp-content/civi-extensions/goonjcustom/Civi/CollectionBaseService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/DroppingCenterService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/GoonjActivitiesService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php (1 hunks)
  • wp-content/plugins/goonj-blocks/build/render.php (2 hunks)
  • wp-content/plugins/goonj-blocks/src/render.php (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tarunnjoshi tarunnjoshi changed the base branch from develop to main December 19, 2024 06:23
@tarunnjoshi tarunnjoshi merged commit fe5cc48 into main Dec 19, 2024
@tarunnjoshi tarunnjoshi deleted the hide-the-custom-group-fixing-acl branch December 19, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant