fix(*) events participants registration#695
Conversation
WalkthroughThis pull request introduces modifications to the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
wp-content/themes/goonj-crm/assets/styles/goonj-main.scss (3)
90-102: Remove or justify commented-out code.
Leaving large blocks of code commented out adds clutter and decreases maintainability. If no longer needed, remove them to keep the stylesheet clean.
248-268: Clean up leftover commented styling.
Similarly to the previous comment, either restore or remove these commented-out sections to maintain clarity. Keeping stale code commented out can confuse future contributors.
269-306: Avoid duplication in SCSS and CSS.
The new rules introduced here appear to replicate logic also present instyle.css. Consider consolidating common styles into a shared partial or variable set to follow DRY (Don't Repeat Yourself) principles and ease maintenance.wp-content/themes/goonj-crm/style.css (1)
15-15: Resolve overriding shorthand property usage.
Static analysis flags thatbackground-image: noneis overridden bybackground: #fff. If intentional, consider removing the earlier property to reduce confusion. Similarly, ensure text-decoration overrides are intentional.- background-image: none !important; background: #fff !important; + background: #fff !important;🧰 Tools
🪛 Biome (1.9.4)
[error] 15-15: Unexpected shorthand property background after background-image
(lint/suspicious/noShorthandPropertyOverrides)
[error] 15-15: Unexpected shorthand property text-decoration after text-decoration-thickness
(lint/suspicious/noShorthandPropertyOverrides)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
wp-content/civi-extensions/goonjcustom/Civi/InductionService.php(1 hunks)wp-content/themes/goonj-crm/assets/styles/goonj-main.scss(2 hunks)wp-content/themes/goonj-crm/style.css(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
wp-content/themes/goonj-crm/style.css
[error] 15-15: Unexpected shorthand property background after background-image
(lint/suspicious/noShorthandPropertyOverrides)
[error] 15-15: Unexpected shorthand property text-decoration after text-decoration-thickness
(lint/suspicious/noShorthandPropertyOverrides)
🔇 Additional comments (2)
wp-content/civi-extensions/goonjcustom/Civi/InductionService.php (2)
458-461: Ensure consistent data structure for subtypes.
Wrapping $newSubtypes in an array is a good defensive check to handle cases where it might be a single non-array value.
461-464:
Fix the critical array index bug for checking 'Volunteer' subtype.
The code currently uses if ($contacts['contact_sub_type' === 'Volunteer']), which always evaluates 'contact_sub_type' === 'Volunteer' to a boolean (false), causing $contacts[false] to be accessed. This is likely a typo and should be if ($contacts['contact_sub_type'] === 'Volunteer').
Apply this diff to correct the condition:
- if ($contacts['contact_sub_type' === 'Volunteer']) {
+ if ($contacts['contact_sub_type'] === 'Volunteer') {
return;
}Likely invalid or redundant comment.
| // fieldset > div:nth-last-child(-n+2) { | ||
| // display: inline; | ||
| // } | ||
|
|
||
| fieldset > div:nth-last-child(3) .label { | ||
| display: none !important; | ||
| } | ||
| // fieldset > div:nth-last-child(3) .label { | ||
| // display: inline !important; | ||
| // } | ||
|
|
||
| fieldset > div:nth-last-child(4) { | ||
| display: none !important; | ||
| } | ||
| // fieldset > div:nth-last-child(4) { | ||
| // display: inline !important; | ||
| // } | ||
|
|
2 participants
Summary by CodeRabbit
New Features
Bug Fixes
Style