Skip to content

material contribution receipt changes#892

Merged
belwalshubham merged 2 commits intodevelopfrom
feat/material-contribution-receipt-changes
Jan 27, 2025
Merged

material contribution receipt changes#892
belwalshubham merged 2 commits intodevelopfrom
feat/material-contribution-receipt-changes

Conversation

@belwalshubham
Copy link
Copy Markdown
Collaborator

@belwalshubham belwalshubham commented Jan 27, 2025

  1. Removed Goonj Address
  2. Removed the team goonj text from receipt

Summary by CodeRabbit

  • UI/UX Changes

    • Removed Goonj address and signature from contribution receipts
    • Commented out 'outcome' tab configuration in institution dropping center service
  • Code Maintenance

    • Simplified receipt HTML generation across multiple service classes

@belwalshubham belwalshubham self-assigned this Jan 27, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 27, 2025

Walkthrough

This pull request involves modifications to three PHP files within the Goonj custom CiviCRM extension. The changes primarily focus on removing specific HTML elements from contribution receipt generation methods and commenting out an 'outcome' tab configuration in the InstitutionDroppingCenterService class. The modifications appear to be simplifying the visual presentation of contribution receipts by removing organization address and signature lines.

Changes

File Change Summary
wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php Commented out 'outcome' tab configuration in getSubscribedEvents method
wp-content/civi-extensions/goonjcustom/Civi/InstitutionMaterialContributionService.php Removed Goonj address and signature lines from receipt HTML
wp-content/civi-extensions/goonjcustom/Civi/MaterialContributionService.php Removed Goonj address and signature lines from receipt HTML

Possibly related PRs

Suggested Labels

status : ready for review

Suggested Reviewers

  • tarunnjoshi
  • nishant22029

Poem

Code scissors snipping away,
Receipts trimmed, less to say
Tabs hidden, secrets kept tight
Simplicity takes flight! ✂️📄
Goonj's essence, lean and bright 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94160c8 and 2c247c9.

📒 Files selected for processing (3)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php (1 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionMaterialContributionService.php (0 hunks)
  • wp-content/civi-extensions/goonjcustom/Civi/MaterialContributionService.php (0 hunks)
💤 Files with no reviewable changes (2)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionMaterialContributionService.php
  • wp-content/civi-extensions/goonjcustom/Civi/MaterialContributionService.php
✅ Files skipped from review due to trivial changes (1)
  • wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@belwalshubham belwalshubham merged commit 9d25578 into develop Jan 27, 2025
@belwalshubham belwalshubham deleted the feat/material-contribution-receipt-changes branch January 27, 2025 14:25
@coderabbitai coderabbitai bot mentioned this pull request Jan 30, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant