Fix the monetary error

[tarunnjoshi]

Fix the monetary error

Summary by CodeRabbit

• Style

  • Made minor formatting improvements to enhance code readability.

• Bug Fixes

  • Refined the logic for associating contributions with campaigns to ensure they are linked correctly.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces minor changes to the CollectionCampService class. A formatting adjustment is applied in the assignChapterGroupToIndividual method. In the updateCampaignForCollectionSourceContribution method, the addSelect call is updated to retrieve an additional campaign_id field, and the logic is modified to check for the existence of contributionCampaignId instead of comparing it to another value. These changes alter how campaign identifiers are handled during contribution processing.

Changes

File	Summary of Changes
wp-content/civi-extensions/goonjcustom/…/CollectionCampService.php	- Formatting adjusted in assignChapterGroupToIndividual - Updated addSelect to include campaign_id in updateCampaignForCollectionSourceContribution - Modified condition to check for the existence of contributionCampaignId

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Service as CollectionCampService
    participant Data as Contribution_Details
    Caller->>Service: Call updateCampaignForCollectionSourceContribution(...)
    Service->>Data: addSelect('Contribution_Details.Source', 'campaign_id')
    Data-->>Service: Return Source & campaign_id
    Service->>Service: Check if contributionCampaignId exists

Loading

Possibly related PRs

• Assign Campaign to Contribution #601: Modifies logic within the updateCampaignForCollectionSourceContribution method.
• Assign Goonj Chapter To Contact #517: Updates the assignChapterGroupToIndividual method with similar formatting adjustments.
• Fix(*) Added check to avoid error of not found #663: Also focuses on campaign ID handling in the updateCampaignForCollectionSourceContribution method.

Suggested labels

status : ready for review

Poem

In lines of code, a tweak unfolds,
Formatting refined as the story's told.
New fields and checks in a gentle dance,
Campaign logic takes its chance.
Code flows like art, debugging's delight,
Cheers to clean builds into the night! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76ef0dc and 1fe2a49.

📒 Files selected for processing (1)

• wp-content/civi-extensions/goonjcustom/Civi/CollectionCampService.php (4 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.