institute relationship changes

[belwalshubham]

Summary by CodeRabbit

• Bug Fixes
  • Standardized coordinator role displays by updating labels across various registration types to "Default Coordinator."
  • Corrected a typographical error in the education category for clearer institution naming.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the internal mapping logic used for assigning coordinators. In both the collection camp and dropping center services, the assignCoordinatorByRelationshipType method now maps registration categories—such as 'Association', 'Associations', and 'Others'—to the generic string "Default Coordinator of". In addition, the InstitutionService class’s getRelationshipTypeName method has been updated to map 'Foundation' and 'Association' to "Default Coordinator of" and corrects the label "Collage/University" to "College/University". Method signatures remain unchanged.

Changes

File(s)	Summary
wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php	Updated the assignCoordinatorByRelationshipType method to use a generic mapping "Default Coordinator of" for registration categories ('Association', 'Associations', and 'Others').
wp-content/civi-extensions/goonjcustom/Civi/InstitutionService.php	Modified the getRelationshipTypeName method to map 'Foundation' and 'Association' to "Default Coordinator of" and fixed the typo from "Collage/University" to "College/University".

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Service as InstCollection/DroppingCenterService
    Client->>Service: assignCoordinatorByRelationshipType(stateOfficeId, registrationType, id)
    Service->>Service: Look up registration mapping for registrationType
    Service-->>Client: Return coordinator assignment ("Default Coordinator of")

Loading

sequenceDiagram
    participant Client
    participant InstService as InstitutionService
    Client->>InstService: getRelationshipTypeName(contactId)
    InstService->>InstService: Evaluate institution type & category
    InstService-->>Client: Return mapped type ("Default Coordinator of" or corrected "College/University")

Loading

Possibly related PRs

• Refactor Institution Collection Camp Service #640: Modifies the mapping in InstitutionCollectionCampService for the 'Association' registration category.
• Prod Release : 5/12/2024 - ACL Implemetation from all eck subtypes #552: Directly connects changes across InstitutionCollectionCampService and InstitutionDroppingCenterService by updating the coordinator assignment mappings.
• add relationship to contact #917: Adjusts the handling of relationship types in the InstitutionService class, aligning with the current changes.

Suggested labels

status : ready for review

Suggested reviewers

• tarunnjoshi

Poem

In lines of code, a fresh rewrite unfurls,
Mapping now carries a simpler world.
From associations to foundations, all is aligned,
"Default Coordinator of" clearly defined.
May these changes guide with precision and cheer—
A neat refactor, bright and clear!
🚀 Happy coding under the clear blue sphere!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 867dd11 and b752ab0.

📒 Files selected for processing (3)

• wp-content/civi-extensions/goonjcustom/Civi/InstitutionCollectionCampService.php (1 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/InstitutionDroppingCenterService.php (1 hunks)
• wp-content/civi-extensions/goonjcustom/Civi/InstitutionService.php (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.