Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

fix: narrow down type hints#472

Merged
redeboer merged 7 commits intomasterfrom
fix-type-hints
Feb 3, 2021
Merged

fix: narrow down type hints#472
redeboer merged 7 commits intomasterfrom
fix-type-hints

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Feb 3, 2021

Spin-off from #470

Sometimes test fails for reasons that could have been pointed out with static typing. This PR fixes some of those problems by narrowing down the type hints.

@redeboer redeboer added 🔨 Maintenance Refactoring that doesn't affect the interface 🖱️ DX Improvements to the Developer Experience labels Feb 3, 2021
@redeboer redeboer self-assigned this Feb 3, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2021

Codecov Report

Merging #472 (ac4c8c7) into master (eb9039e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          22       22           
  Lines        3272     3272           
  Branches      831      831           
=======================================
  Hits         2939     2939           
  Misses        172      172           
  Partials      161      161           
Flag Coverage Δ
unittests 89.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/reaction/topology.py 88.33% <100.00%> (ø)

@redeboer redeboer merged commit 21236b0 into master Feb 3, 2021
@redeboer redeboer deleted the fix-type-hints branch February 3, 2021 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🖱️ DX Improvements to the Developer Experience 🔨 Maintenance Refactoring that doesn't affect the interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant