Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

refactor: improve topology building interfaces#477

Merged
redeboer merged 8 commits intomasterfrom
improve-topology-builder
Feb 3, 2021
Merged

refactor: improve topology building interfaces#477
redeboer merged 8 commits intomasterfrom
improve-topology-builder

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Feb 3, 2021

Adds façade functions create_n_body_decay and create_isobar_topology and simplifies the interface of SimpleStateTransitionTopologyBuilder and InteractionNode a bit.

@redeboer redeboer added the ⚠️ Interface Changes to the interface label Feb 3, 2021
@redeboer redeboer self-assigned this Feb 3, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2021

Codecov Report

Merging #477 (8be3d82) into master (04bb696) will decrease coverage by 0.06%.
The diff coverage is 86.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   89.77%   89.71%   -0.07%     
==========================================
  Files          22       22              
  Lines        3277     3285       +8     
  Branches      831      835       +4     
==========================================
+ Hits         2942     2947       +5     
- Misses        173      175       +2     
- Partials      162      163       +1     
Flag Coverage Δ
unittests 89.71% <86.17%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/reaction/__init__.py 86.95% <66.66%> (-0.11%) ⬇️
src/expertsystem/reaction/topology.py 87.74% <87.50%> (-0.60%) ⬇️

@redeboer redeboer merged commit 06e417f into master Feb 3, 2021
@redeboer redeboer deleted the improve-topology-builder branch February 3, 2021 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚠️ Interface Changes to the interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant