This repository was archived by the owner on Oct 11, 2021. It is now read-only.
refactor: remove graph_node_comparator from STG#478
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 89.71% 90.15% +0.44%
==========================================
Files 22 22
Lines 3285 3270 -15
Branches 835 828 -7
==========================================
+ Hits 2947 2948 +1
+ Misses 175 166 -9
+ Partials 163 156 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StateTransitionGraph.comparemethod provides a sufficient handle to compare graphs. So better not to have an STG carry around its own comparator (theSTGis in first instance just a mapping of edge and node properties for some underlying topology).