Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

refactor: rename solutions to transitions#481

Merged
redeboer merged 2 commits intomasterfrom
Solution.transitions
Feb 5, 2021
Merged

refactor: rename solutions to transitions#481
redeboer merged 2 commits intomasterfrom
Solution.transitions

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Feb 5, 2021

The Result class by now (#459) is just a container with a solutions list and a formalism_type. In the long term, the idea is that generate_transitions only returns transitions as a StateTransitionCollection object (see #458) and that a formalism_type does not have to be carried around within the reaction module (#168).

In preparation to this, the variable names are shifting from graph/solution to transition.

@redeboer redeboer added the ⚠️ Interface Changes to the interface label Feb 5, 2021
@redeboer redeboer self-assigned this Feb 5, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2021

Codecov Report

Merging #481 (2f9d4a1) into master (0f1e5bd) will not change coverage.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files          22       22           
  Lines        3296     3296           
  Branches      830      830           
=======================================
  Hits         2968     2968           
  Misses        170      170           
  Partials      158      158           
Flag Coverage Δ
unittests 90.04% <90.90%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/reaction/__init__.py 86.53% <88.88%> (ø)
src/expertsystem/amplitude/helicity_decay.py 90.34% <100.00%> (ø)

@redeboer redeboer force-pushed the Solution.transitions branch from ffbeaff to 20396f7 Compare February 5, 2021 12:04
@redeboer redeboer changed the title refactor: rename Result to Solution.transitions refactor: rename solutions to transitions Feb 5, 2021
@redeboer redeboer merged commit 1caa526 into master Feb 5, 2021
@redeboer redeboer deleted the Solution.transitions branch February 5, 2021 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚠️ Interface Changes to the interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant