This repository was archived by the owner on Oct 11, 2021. It is now read-only.
refactor: rename solutions to transitions#481
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 22 22
Lines 3296 3296
Branches 830 830
=======================================
Hits 2968 2968
Misses 170 170
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ffbeaff to
20396f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Resultclass by now (#459) is just a container with asolutionslist and aformalism_type. In the long term, the idea is thatgenerate_transitionsonly returnstransitionsas aStateTransitionCollectionobject (see #458) and that aformalism_typedoes not have to be carried around within thereactionmodule (#168).In preparation to this, the variable names are shifting from
graph/solutiontotransition.