Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

feat: add option to change width factor#484

Merged
redeboer merged 1 commit intomasterfrom
mass-conservation-factor
Feb 8, 2021
Merged

feat: add option to change width factor#484
redeboer merged 1 commit intomasterfrom
mass-conservation-factor

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Feb 5, 2021

Closes #355

A better solution would come through #169, but for now this is a necessary feature that only adds to the interfaces.

@redeboer redeboer requested a review from spflueger February 5, 2021 18:50
@redeboer redeboer self-assigned this Feb 5, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2021

Codecov Report

Merging #484 (c80118d) into master (1c9851a) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   89.60%   89.60%   -0.01%     
==========================================
  Files          22       22              
  Lines        3310     3309       -1     
  Branches      836      836              
==========================================
- Hits         2966     2965       -1     
  Misses        184      184              
  Partials      160      160              
Flag Coverage Δ
unittests 89.60% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/reaction/__init__.py 83.57% <66.66%> (-0.04%) ⬇️
src/expertsystem/reaction/default_settings.py 80.64% <66.66%> (ø)

@redeboer redeboer added the 💡 Feature New feature added to the package label Feb 5, 2021
Copy link
Copy Markdown
Member

@spflueger spflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@redeboer redeboer force-pushed the mass-conservation-factor branch from 0fe350b to c7e49f5 Compare February 8, 2021 10:23
@redeboer redeboer merged commit 192d2ae into master Feb 8, 2021
@redeboer redeboer deleted the mass-conservation-factor branch February 8, 2021 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

💡 Feature New feature added to the package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow user to modify width in mass conservation rule

2 participants