Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

fix: improve exception message violated rules#485

Merged
redeboer merged 2 commits intomasterfrom
violated-rule-exceptions
Feb 8, 2021
Merged

fix: improve exception message violated rules#485
redeboer merged 2 commits intomasterfrom
violated-rule-exceptions

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Feb 7, 2021

Makes the exception message more readable. Previously, only the entire edge ID to rule mapping dict was dumped.

@redeboer redeboer added the 💡 Feature New feature added to the package label Feb 7, 2021
@redeboer redeboer requested a review from spflueger February 7, 2021 18:25
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2021

Codecov Report

Merging #485 (4ebeea2) into master (1caa526) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   89.98%   89.66%   -0.33%     
==========================================
  Files          22       22              
  Lines        3296     3310      +14     
  Branches      830      836       +6     
==========================================
+ Hits         2966     2968       +2     
- Misses        171      183      +12     
  Partials      159      159              
Flag Coverage Δ
unittests 89.66% <0.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/reaction/__init__.py 83.61% <0.00%> (-2.92%) ⬇️
src/expertsystem/amplitude/helicity_decay.py 90.34% <0.00%> (+0.77%) ⬆️

@redeboer redeboer merged commit 1c9851a into master Feb 8, 2021
@redeboer redeboer deleted the violated-rule-exceptions branch February 8, 2021 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

💡 Feature New feature added to the package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants