This repository was archived by the owner on Oct 11, 2021. It is now read-only.
Conversation
Somehow if the metadata contains "nbformat_minor": 5 instead of "nbformat_minor": 4 nbstripout and jupyter lab add randomly generated cell ids to the cell metadata
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 89.26% 89.20% -0.06%
==========================================
Files 22 22
Lines 3334 3334
Branches 844 844
==========================================
- Hits 2976 2974 -2
- Misses 194 195 +1
- Partials 164 165 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Note: I initially suspected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow if a Jupyter notebook contains
in its top-level structure, instead of
both
nbstripoutand Jupyter lab add randomly generated cell IDs to each cell. This is super bothersome for diffs and merge conflicts. Worst part is that the IDs are random which causes a lot of unnecessary file changes.This PR removes the
"id"items and lowers thenbformat_minor. With the current dev set-up (pinned versions ofjupyterlabetc) new notebooks will again get"nbformat_minor": 5, but I'm not sure how to work around this. Just something to keep an eye on now.