This repository was archived by the owner on Oct 11, 2021. It is now read-only.
fix: allow Iterable in Topology constructor#498
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 89.26% 89.21% -0.05%
==========================================
Files 22 22
Lines 3334 3338 +4
Branches 844 845 +1
==========================================
+ Hits 2976 2978 +2
- Misses 194 195 +1
- Partials 164 165 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the constructor
Topologyallows one to usenodes={0, 1}(thesetis cast internally to afrozenset),mypysays this is not allowed. This PR fixes this behaviour.