Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

refactor: use UPPER_CASE for Enum members#499

Merged
redeboer merged 3 commits intomasterfrom
create-pull-request/patch-1613960514
Feb 22, 2021
Merged

refactor: use UPPER_CASE for Enum members#499
redeboer merged 3 commits intomasterfrom
create-pull-request/patch-1613960514

Conversation

@redeboer
Copy link
Copy Markdown
Member

@redeboer redeboer commented Feb 22, 2021

Pylint 2.7.0 now checks whether members of an Enum are UPPER_CASE
http://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-7-0

Automated changes by create-pull-request GitHub action

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Feb 22, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2021

Codecov Report

Merging #499 (c360ec2) into master (2061d31) will not change coverage.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          22       22           
  Lines        3338     3338           
  Branches      845      845           
=======================================
  Hits         2980     2980           
  Misses        194      194           
  Partials      164      164           
Flag Coverage Δ
unittests 89.27% <92.85%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/reaction/_system_control.py 89.72% <0.00%> (ø)
src/expertsystem/amplitude/model.py 93.80% <100.00%> (ø)
src/expertsystem/reaction/__init__.py 83.57% <100.00%> (ø)
src/expertsystem/reaction/default_settings.py 80.64% <100.00%> (ø)

@redeboer redeboer changed the title ci: upgrade developer dependencies refactor: use UPPER_CASE for enum members Feb 22, 2021
@redeboer redeboer changed the title refactor: use UPPER_CASE for enum members refactor: use UPPER_CASE for Enum members Feb 22, 2021
@redeboer redeboer self-assigned this Feb 22, 2021
@redeboer redeboer added ⚠️ Interface Changes to the interface and removed 🖱️ DX Improvements to the Developer Experience labels Feb 22, 2021
@redeboer redeboer requested review from spflueger and removed request for spflueger February 22, 2021 09:01
@redeboer redeboer merged commit ebaa93b into master Feb 22, 2021
@redeboer redeboer deleted the create-pull-request/patch-1613960514 branch February 22, 2021 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚠️ Interface Changes to the interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants