This repository was archived by the owner on Oct 11, 2021. It is now read-only.
refactor: move Result.collapse_graphs to io._dot#523
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
- Coverage 86.20% 86.13% -0.08%
==========================================
Files 22 22
Lines 3575 3585 +10
Branches 871 876 +5
==========================================
+ Hits 3082 3088 +6
- Misses 316 318 +2
- Partials 177 179 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
redeboer
force-pushed
the
remove-collapse_graphs
branch
from
9bd05ec to
e206f95
Compare
This is possible now that io is not a dependency of reaction.
redeboer
force-pushed
the
remove-collapse_graphs
branch
from
e206f95 to
4396df0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the
Resultclass by moving itscollapse_graphs()andget_particle_graphs()methods toio._dot. (This is possible sinceiohas been removed as a dependency of thereactionmodule in #519.) The collapse methods were used for visualization only.