This repository was archived by the owner on Oct 11, 2021. It is now read-only.
refactor: rename parameters to parameter_defaults#531
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 86.10% 86.11% +0.01%
==========================================
Files 22 22
Lines 3584 3587 +3
Branches 876 876
==========================================
+ Hits 3086 3089 +3
Misses 319 319
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4ddce6c to
9b415d9
Compare
Dictionaries are mutable and therefore should be 'protected' in a frozen class
9b415d9 to
2d9cdfb
Compare
Member
|
Sounds reasonable here. Mostly because these parameters are not connected to the model. Only if you do some action like Also I should add, the crucial information of that dictionary is the names of the parameters. So that the distinction between parameters and variables of the model can be made. The default values are more some convenience feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This naming makes more sense, as
HelicityModel.parameterssounds like some sequence that lists the parameters in the model, while it's actually a mapping of those parameters to default ('suggested') values.