This repository was archived by the owner on Oct 11, 2021. It is now read-only.
refactor!: move particle module to reaction#551
Merged
Conversation
Member
Author
|
In addition, note that at this stage it starts to make more sense to split the |
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 22 22
Lines 3636 3636
Branches 885 885
=======================================
Hits 3139 3139
Misses 320 320
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
|
spflueger
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
particlemodule was originally under a separate module, because it could theoretically operate on its own. However, since its main classesParticle,ParticleCollectionandSpinmerely serve as user interfaces to thereactionmodule, it's better to move it back into thereactionmodule.This PR also enables #372, which was currently not possible due to cyclic imports.