Skip to content
This repository was archived by the owner on Oct 11, 2021. It is now read-only.

refactor: use GellMann-Nishijima rule in particle mod#552

Merged
redeboer merged 7 commits intomasterfrom
gellmann
Mar 29, 2021
Merged

refactor: use GellMann-Nishijima rule in particle mod#552
redeboer merged 7 commits intomasterfrom
gellmann

Conversation

@redeboer
Copy link
Copy Markdown
Member

Closes #372

@redeboer redeboer added the 🔨 Maintenance Refactoring that doesn't affect the interface label Mar 29, 2021
@redeboer redeboer added this to the Release 0.8.0 milestone Mar 29, 2021
@redeboer
Copy link
Copy Markdown
Member Author

@spflueger Seems to work, only the tests fail because there's something wrong with the way the rule is used in the post init check of Particle.

Co-authored-by: spflueger <spfluege@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2021

Codecov Report

Merging #552 (3d13ff8) into master (e7fc5ab) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   86.27%   86.23%   -0.05%     
==========================================
  Files          22       22              
  Lines        3636     3625      -11     
  Branches      885      884       -1     
==========================================
- Hits         3137     3126      -11     
  Misses        321      321              
  Partials      178      178              
Flag Coverage Δ
unittests 86.23% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/amplitude/_graph_info.py 81.96% <100.00%> (ø)
src/expertsystem/amplitude/helicity.py 85.62% <100.00%> (-0.05%) ⬇️
src/expertsystem/amplitude/kinematics.py 84.09% <100.00%> (-0.12%) ⬇️
src/expertsystem/reaction/__init__.py 83.05% <100.00%> (ø)
src/expertsystem/reaction/_system_control.py 89.72% <100.00%> (ø)
src/expertsystem/reaction/combinatorics.py 90.79% <100.00%> (-0.19%) ⬇️
src/expertsystem/reaction/conservation_rules.py 92.12% <100.00%> (-0.03%) ⬇️
src/expertsystem/reaction/particle.py 93.22% <100.00%> (-0.71%) ⬇️
src/expertsystem/reaction/quantum_numbers.py 100.00% <100.00%> (ø)

@redeboer redeboer requested a review from spflueger March 29, 2021 16:31
Copy link
Copy Markdown
Member

@spflueger spflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@redeboer redeboer merged commit 283185c into master Mar 29, 2021
@redeboer redeboer deleted the gellmann branch March 29, 2021 16:48
@redeboer redeboer modified the milestones: Release 0.8.0, 0.7.3 Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔨 Maintenance Refactoring that doesn't affect the interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the Gellmann Nishijima rule in the Particle initialization

2 participants