Skip to content

FIX: support ProblemSet.intermediate_states #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

FIX: support ProblemSet.intermediate_states #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d7b13
DX: add test for `ProblemSet.intermediate_states`
redeboer Mar 31, 2025
87660dd
FIX: do not get non-existing IDs with `filter_states()`
redeboer Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/qrules/topology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ def intermediate_states(self) -> dict[int, EdgeType]:

def filter_states(self, edge_ids: Iterable[int]) -> dict[int, EdgeType]:
"""Filter `states` by a selection of :code:`edge_ids`."""
return {i: self.states[i] for i in edge_ids}
return {i: self.states[i] for i in edge_ids if i in self.states}


@implement_pretty_repr
Expand Down
17 changes: 17 additions & 0 deletions tests/unit/test_transition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,23 @@
NAMESPACE_WITH_FRACTIONS["Fraction"] = Fraction


class TestMutableTransition:
def test_intermediate_states(self):
stm = StateTransitionManager(
initial_state=[("J/psi(1S)", [-1, +1])],
final_state=["K0", "Sigma+", "p~"],
allowed_intermediate_particles=["N(1700)", "Sigma(1750)"],
formalism="helicity",
mass_conservation_factor=0,
)
stm.set_allowed_interaction_types([InteractionType.STRONG, InteractionType.EM])
problem_sets = stm.create_problem_sets()
some_problem_set = problem_sets[3600.0][0]
assert set(some_problem_set.initial_facts.initial_states) == {-1}
assert set(some_problem_set.initial_facts.final_states) == {0, 1, 2}
assert set(some_problem_set.initial_facts.intermediate_states) == set()


class TestReactionInfo:
def test_properties(self, reaction: ReactionInfo):
assert reaction.initial_state[-1].name == "J/psi(1S)"
Expand Down