Skip to content

Feat/add enable decoupled for smiles, smiles validation and update folder name#20

Merged
phuang26 merged 2 commits intomainfrom
feat/add-smiles-validation-and-update-folder-name
Oct 22, 2025
Merged

Feat/add enable decoupled for smiles, smiles validation and update folder name#20
phuang26 merged 2 commits intomainfrom
feat/add-smiles-validation-and-update-folder-name

Conversation

@alizaib1217
Copy link
Collaborator

@alizaib1217 alizaib1217 commented Oct 22, 2025

📝 PR Description

Fix folder naming, improve SMILES validation, and decouple the checkbox

What's Fixed

Folder Naming (Issue #12)

  • Users no longer get unnecessary _1 suffixes on unique folder names
  • Fixed cross-hierarchy conflicts where folders in different locations would incorrectly conflict
  • Example: Creating "my_product" now stays "my_product" instead of becoming "my_product_1"

Enable Decoupled checkbox and SMILES Validation (Issue #19)

  • Enable decoupled checkbox for smiles
  • Enhanced to catch invalid aromatic atoms like "c.Na" while still accepting valid rings like
    "c1ccccc1"
  • Simple red/green feedback for users

@alizaib1217 alizaib1217 self-assigned this Oct 22, 2025
  - Add validateSMILES() function to validate SMILES strings
  - Update useMolValidation hook to check both molfile and cano_smiles
  - Decoupled field now becomes editable when either molfile or cano_smiles is valid

feat: add visual validation feedback for cano_smiles field

fix: improve folder naming and SMILES validation Fixed unnecessary _1 suffixes on unique folder names and cross-hierarchy naming conflicts. Enhanced SMILES validation to catch isolated aromatic atoms while keeping simple red/green feedback.
  Fixed unnecessary _1 suffixes on unique folder names and cross-hierarchy
  naming conflicts. Enhanced SMILES validation to catch isolated aromatic
  atoms while keeping simple red/green feedback.
@alizaib1217 alizaib1217 force-pushed the feat/add-smiles-validation-and-update-folder-name branch from 35879c4 to 39a26ae Compare October 22, 2025 08:45
@alizaib1217 alizaib1217 marked this pull request as ready for review October 22, 2025 08:52
@alizaib1217 alizaib1217 changed the title Feat/add smiles validation and update folder name Feat/add enable decoupled for smiles, smiles validation and update folder name Oct 22, 2025
@phuang26 phuang26 merged commit 9948bd0 into main Oct 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable decoupled checkbox for smiles also imrpove validation for smiles remove "_1" from folder name craetion

2 participants