Improve MetricRegistryFactory configuration#39
Merged
kristomasette merged 2 commits intoComcast:masterfrom Jan 8, 2016
Merged
Conversation
b28fea1 to
4a08773
Compare
Current coverage is
|
Contributor
There was a problem hiding this comment.
should this be: getLogger("com.comcast.money.metrics.MetricRegistryExtensionImpl")
Contributor
|
one minor nit to pick, but otherwise, looks good |
Contributor
There was a problem hiding this comment.
can you use /* instead of multiple lines of //
Member
Author
|
Addressed @kristomasette and @paulcleary comments |
Contributor
|
👍 |
The current appraoch requires two properties to be set to enable a
custom MetricRegistryFactory:
```
metrics-registry {
class-name = "com.acme.CustomMetricRegistryFactory"
}
emitter {
emitters = [
{
name = "span-metrics-emitter"
class-name = "com.comcast.money.metrics.SpanMetricsCollector"
subscriptions = [Trace]
configuration = {
metrics-registry {
class-name = "com.acme.CustomMetricRegistryFactory"
}
}
}
]
}
```
With this change, the configuration simplifies down to
```
metrics-registry {
class-name = "com.acme.CustomMetricRegistryFactory"
configuration = {
}
}
```
for the money system and providing a custom 'configuration' section for the factory.
Also, as it is now an Akka extension, the factory is created only once for the whole system.
kristomasette
added a commit
that referenced
this pull request
Jan 8, 2016
Improve MetricRegistryFactory configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current appraoch requires two properties to be set to enable a
custom MetricRegistryFactory:
With this change, the configuration simplifies down to
for the money system and providing a custom 'configuration' section for the factory.
Also, as it is now an Akka extension, the factory is created only once for the whole system.