Check recv topic before match attempt#108
Merged
Merged
Conversation
jsccast
requested review from
carlos-loya,
dnalinikumar,
hemanjayam,
robertfarnum and
rrapant
Collaborator
robertfarnum
left a comment
robertfarnum
left a comment
There was a problem hiding this comment.
Lot's of changes, cognitive complexity overload. I wonder if there is anyway to break up this function?
Member
Author
Yeah, it looks bad, but it's really the same code that just indented for the conditional body. But I still agree: see #109! I thought it'd be better to fix the topic handling separate from breaking up |
robertfarnum
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104.