Feature: Add support for flex column width #2839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 94.02% 94.35% +0.32%
==========================================
Files 38 38
Lines 1256 1258 +2
Branches 403 405 +2
==========================================
+ Hits 1181 1187 +6
+ Misses 75 71 -4
|
amanmahajan7
changed the title
amanmahajan7
commented
Mar 16, 2022
| left: number; | ||
| } | ||
|
|
||
| const DEFAULT_COLUMN_WIDTH = 'auto'; |
| if (typeof width === 'number') { | ||
| return width; | ||
| } | ||
| if (typeof width === 'string' && /^\d+%$/.test(width)) { |
There was a problem hiding this comment.
No longer needed as we get the width after the columns are rendered
Merged
nstepien
reviewed
Sep 15, 2022
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
nstepien
reviewed
Sep 16, 2022
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
This reverts commit 151d724.
nstepien
approved these changes
Sep 16, 2022
keriat
pushed a commit
to superform-xyz/react-data-grid
that referenced
this pull request
Jan 10, 2024
## [5.1.0](v5.0.4...5.1.0) (2024-01-10) ### Features * Add DataGridComponentsProvider component and DataGrid.components prop ([Comcast#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291)) * Add support for flex column width ([Comcast#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad)) * expose scroll event ([Comcast#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e)) * RTL ([Comcast#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63)) * semantic release installed and configured ([e71bfe6](e71bfe6)) ### Bug Fixes * drag jumps to the right due to the failed merge ([Comcast#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b)) * isSelectedCellEditable row getter idx ([Comcast#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137)) * package-lock.json added to version control ([df39113](df39113)) ### Reverts * Revert "Dependabot: set versioning-strategy to increase (Comcast#2479)" (Comcast#2511) ([0bedc81](0bedc81))
keriat
pushed a commit
to superform-xyz/react-data-grid
that referenced
this pull request
Jan 10, 2024
## [5.1.0](v5.0.4...5.1.0) (2024-01-10) ### Features * Add DataGridComponentsProvider component and DataGrid.components prop ([Comcast#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291)) * Add support for flex column width ([Comcast#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad)) * expose scroll event ([Comcast#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e)) * RTL ([Comcast#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63)) * semantic release installed and configured ([e71bfe6](e71bfe6)) ### Bug Fixes * drag jumps to the right due to the failed merge ([Comcast#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b)) * isSelectedCellEditable row getter idx ([Comcast#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137)) * package-lock.json added to version control ([df39113](df39113)) ### Reverts * Revert "Dependabot: set versioning-strategy to increase (Comcast#2479)" (Comcast#2511) ([0bedc81](0bedc81))
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Add support for "auto" width * Calculate columns when grid width is set * Remove unnecessary code * Add support for css column units (fr, %, max-content) * Bring back virtualization * Remove console * Fix minWidth and examples * Add min width * Disable @typescript-eslint/naming-convention * Add comments * Revent some changes * Use getBoundingClientRect * Rename variables * support flex width on all the columns * Fix tests * Update src/DataGrid.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Address a few comments * Move width type close to minWidth * Do not reset max-content columns * Remove flexColumnWidths state * Add max-content example * Update src/DataGrid.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Fix classname * Update src/hooks/useGridDimensions.ts Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Remove useMemo * Add back useMemo * tweak autosizeColumnsClassname for better measuring * Revert "tweak autosizeColumnsClassname for better measuring" This reverts commit 151d724. Co-authored-by: Aman Mahajan <amahajan@freewheel.tv> Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> Co-authored-by: Nicolas Stepien <stepien.nicolas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column now supports CSS grid units including
auto(default),fr,%,max-contentetc. To handle virtualization, a flex column is assigned a width of (80px) and the actual width is calculated after the grid is rendered.