Fix min/max width #2855
Merged
Fix min/max width #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2022 16:48
Codecov Report
@@ Coverage Diff @@
## main #2855 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 37 38 +1
Lines 1244 1244
Branches 392 391 -1
=======================================
Hits 1197 1197
Misses 47 47
|
amanmahajan7
commented
Mar 16, 2022
| isLastFrozenColumn: false, | ||
| rowGroup, | ||
| width: rawColumn.width ?? defaultWidth, | ||
| minWidth: rawColumn.minWidth ?? defaultMinWidth, |
There was a problem hiding this comment.
This way we initialize widths once and use them everywhere
https://github.com/adazzle/react-data-grid/blob/main/src/HeaderCell.tsx#L178
| key: SELECT_COLUMN_KEY, | ||
| name: '', | ||
| width: 35, | ||
| minWidth: 35, |
There was a problem hiding this comment.
Needed now as the default min width is 80
| { selector: 'typeLike', format: ['PascalCase'] } | ||
| ], | ||
| // TODO: fix | ||
| '@typescript-eslint/naming-convention': 0, |
There was a problem hiding this comment.
Not sure if this a bug or needs to be tweaked
| const width = isRtl ? right + offset - event.clientX : event.clientX + offset - left; | ||
| if (width > 0) { | ||
| onColumnResize(column, width); | ||
| onColumnResize(column, clampColumnWidth(width, column)); |
There was a problem hiding this comment.
Otherwise DataGrid.onColumnResize is called with wrong width as it does not respect min/max width
| @@ -0,0 +1,40 @@ | |||
| import type { CSSProperties } from 'react'; | |||
There was a problem hiding this comment.
Moved style utils to a separate file
nstepien
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked changes from #2839