Fix double-click to auto-size columns #3744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3744 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 47 47
Lines 3426 3426
Branches 743 742 -1
=======================================
Hits 3380 3380
Misses 46 46
🚀 New features to boost your workflow:
|
amanmahajan7
approved these changes
Mar 19, 2025
| const resizeHandle = page.elementLocator(getResizeHandle(column)); | ||
|
|
||
| await userEvent.dblClick(resizeHandle); | ||
| await resizeHandle.dblClick(); |
Collaborator
There was a problem hiding this comment.
Any reason for this change?
Collaborator
Author
There was a problem hiding this comment.
I wanted to see if the order of events would reflect actual browser behavior, as userEvent does not perform real browser/cursor actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need
hasDoubleClickedRefin practice as the double click event happens afterlostpointercapture, but it does happen beforelostpointercapturein tests for some reason.