Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
===========================================
- Coverage 100.00% 97.84% -2.16%
===========================================
Files 46 42 -4
Lines 3200 1253 -1947
Branches 414 348 -66
===========================================
- Hits 3200 1226 -1974
- Misses 0 27 +27 🚀 New features to boost your workflow:
|
amanmahajan7
commented
Sep 16, 2025
| } | ||
| } | ||
|
|
||
| export async function tabIntoGrid() { |
Collaborator
Author
There was a problem hiding this comment.
Added this utility so we can control tabbing into the grid
amanmahajan7
commented
Sep 16, 2025
| const grid = getGrid(); | ||
| await expect.element(grid).toHaveStyle({ gridTemplateColumns: '639.328px 639.328px 639.344px' }); | ||
|
|
||
| function testGridTemplateColumns(chrome: string, firefox: string, firefoxCI = firefox) { |
Collaborator
Author
There was a problem hiding this comment.
Is there a better way? I initially thought about using toBeCloseTo but FF in CI has completely different column size. No idea why
amanmahajan7
commented
Sep 19, 2025
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-node@v5 | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 |
Collaborator
Author
There was a problem hiding this comment.
started failing recently
https://github.com/adazzle/react-data-grid/actions/runs/17775660504/job/50710625456
Collaborator
Author
There was a problem hiding this comment.
nstepien
reviewed
Sep 22, 2025
| await userEvent.tab(); | ||
| await expect.element(editor).not.toBeInTheDocument(); | ||
| expect(getCellsAtRowIndex(0)[0]).toHaveTextContent(/^12$/); | ||
| expect(getCellsAtRowIndex(0)[0]).toHaveTextContent(12); |
Collaborator
There was a problem hiding this comment.
Should we not keep the strict check?
| await userEvent.click(getCellsAtRowIndex(0)[0]); | ||
| await userEvent.keyboard('123{enter}'); | ||
| expect(getCellsAtRowIndex(0)[0]).toHaveTextContent(/^1123$/); | ||
| // TODO: await userEvent.keyboard('123{enter}'); fails in FF |
Collaborator
There was a problem hiding this comment.
Sounds like a bug in RDG no?
Collaborator
Author
There was a problem hiding this comment.
Works fine in FF when I tested. Test is failing for some reason
| expect(onColumnResize).toHaveBeenCalledExactlyOnceWith( | ||
| expect.objectContaining(columns[1]), | ||
| 327.703125 | ||
| expect.toSatisfy((width) => (width >= 327.7 && width <= 327.9) || width === 400) |
Collaborator
There was a problem hiding this comment.
Could add comment explaining this
Comment on lines
+346
to
+347
| firefox, | ||
| firefoxCI |
Collaborator
There was a problem hiding this comment.
Why is it so different in CI? 🤔
nstepien
reviewed
Sep 22, 2025
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
|
|
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
nstepien
approved these changes
Sep 22, 2025
royue
pushed a commit
to royue/react-data-grid
that referenced
this pull request
Dec 17, 2025
* Run tests in FF * Fix editor test, use istanbul for coverage * Remove optimizeDeps * revert 1 change * Fix keyboard tests * Revert * Fix rowHeight tests * Fix focus in FF * headless * ESLint * Tweak focus logic * Fix test * Fix test in FF * Revert firefox workaround * try beta version * Revert "try beta version" This reverts commit a00f60e. * Try pinning vitest * Revert "Try pinning vitest" This reverts commit faafac2. * Revrt timeout * try `maxWorkers` * `maxWorkers: 4,` * increate testTimeout * try beta * Fix grouping test * Fix a few tests * Format * Use stable version * -1 * -1 * -1 * -2 * tryl gridcell role * biome * Remove timeout * Does this work? * Set maxWorkers = 1 * revert a few changes * Revert 1 more change * one more * Revert a few more changes * Fix resizable test * Add speciial case for firefox CI * revert 1 change * Fix test * Revert accidental change * tweak * Use SHA * remove `react-dnd` pattern * Disable `fileParallelism` * Check chrome explicitly * Use strick check * Add a comment * Update test/browser/column/renderEditCell.test.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> * Update test/browser/column/renderEditCell.test.tsx Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> --------- Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in FF timeout when more than one worker is used. Probably a bug
https://vitest.dev/config/#fileparallelism