Fix a few accessibility issues#3816
Merged
amanmahajan7 merged 7 commits intomainfrom Jun 24, 2025
Merged
Conversation
amanmahajan7
commented
Jun 23, 2025
| return ( | ||
| <header className={headerClassname}> | ||
| <h1 id={headerId}>react-data-grid</h1> | ||
| <nav aria-labelledby={demosNavId} className={navClassname}> |
Collaborator
Author
There was a problem hiding this comment.
Added accessible name so screen reader can announce it like Demos navigation landmark
| <a href="https://github.com/adazzle/react-data-grid/issues" target="_blank" rel="noreferrer"> | ||
| Issues | ||
| </a> | ||
| <nav aria-labelledby={linksNavId} className={navClassname}> |
Collaborator
Author
There was a problem hiding this comment.
This is not part of demos so I have split these navs
nstepien
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aria-labelto all grids