Skip to content

Validate position before rendering editor#3849

Merged
amanmahajan7 merged 1 commit intomainfrom
undefined
Aug 22, 2025
Merged

Validate position before rendering editor#3849
amanmahajan7 merged 1 commit intomainfrom
undefined

Conversation

@amanmahajan7
Copy link
Copy Markdown
Collaborator

Fixes #3136

You can check the error here
https://codesandbox.io/p/sandbox/goofy-dust-gzcv4v

@amanmahajan7 amanmahajan7 self-assigned this Aug 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.60%. Comparing base (6c51d7e) to head (7799a04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3849   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          46       46           
  Lines        3500     3507    +7     
  Branches      767      770    +3     
=======================================
+ Hits         3451     3458    +7     
  Misses         49       49           
Files with missing lines Coverage Δ
src/DataGrid.tsx 99.48% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanmahajan7 amanmahajan7 marked this pull request as ready for review August 22, 2025 02:55
@amanmahajan7 amanmahajan7 requested a review from nstepien as a code owner August 22, 2025 02:55
@amanmahajan7 amanmahajan7 merged commit 1ceb853 into main Aug 22, 2025
2 checks passed
@amanmahajan7 amanmahajan7 deleted the undefined branch August 22, 2025 14:27
royue pushed a commit to royue/react-data-grid that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash if a column is removed while editing

2 participants