Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3998 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 37 37
Lines 1470 1470
Branches 471 471
=======================================
Hits 1432 1432
Misses 38 38 🚀 New features to boost your workflow:
|
nstepien
changed the title
| with: | ||
| name: test-artifacts | ||
| path: | | ||
| test/browser/**/__screenshots__/** |
There was a problem hiding this comment.
So we add visual screenshots and failed screenshots in the same directory? Wonder if we should change screenshotDirectory for browser tests? I think we may have to upload https://vitest.dev/guide/cli.html#attachmentsdir. Can you check if the diff screenshots are uploaded
There was a problem hiding this comment.
So we add visual screenshots and failed screenshots in the same directory?
This only captures screenshots from failed tests (test/browser), this won't upload screenshots from visual tests (tests/visual).
Wonder if we should change
screenshotDirectoryfor browser tests?
No need, we can already target them with the test/browser path.
I think we may have to upload https://vitest.dev/guide/cli.html#attachmentsdir
Done
Can you check if the diff screenshots are uploaded
It does now.
https://github.com/Comcast/react-data-grid/actions/runs/22916570893/artifacts/5855351059
| name: test-artifacts | ||
| path: | | ||
| test/browser/**/__screenshots__/** | ||
| test/browser/**/__traces__/** |
There was a problem hiding this comment.
| test/browser/**/__traces__/** |
Do we generate traces?
There was a problem hiding this comment.
We do not. I kept it in case we ever want to enable and debug them.
3 participants
No description provided.