Conversation
amanmahajan7
approved these changes
Mar 10, 2026
Comment on lines
+10
to
+11
| const col1Editor = page.getByRole('spinbutton', { name: 'col1-editor' }); | ||
| const col2Editor = page.getByRole('textbox', { name: 'col2-editor' }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve this flaky test failure:
https://github.com/Comcast/react-data-grid/actions/runs/22867372688/job/66337693800
I couldn't figure out the exact reason why this was flaky, just that sometimes the grid only scrolled from top: 0px to top: 9px instead of top: 1500px.
My hunch is that it's related to the editor's
autoFocusattributew, or to keyboard interactions fromawait userEvent.keyboard('abc');.I've also removed
tracefrom vitest's config, as it slows down tests when enabled, and leads to slightly different timing behavior between CI and local dev.It can be re-enabled as needed, to debug, but I don't think we need to keep it enabled in general.