Skip to content

Adding configurable filter header height#650

Merged
malonecj merged 2 commits intoComcast:masterfrom
pkasperowicz:Custom_Filter_Header_Height
Feb 21, 2017
Merged

Adding configurable filter header height#650
malonecj merged 2 commits intoComcast:masterfrom
pkasperowicz:Custom_Filter_Header_Height

Conversation

@pkasperowicz
Copy link

Description

Filter header has fixed height 45px. Added prop for the configurable height with default 45px.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The height of columns is fixed to 45px.

What is the new behavior?
The height of columns can be configured.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bde5d47 on pkasperowicz:Custom_Filter_Header_Height into ** on adazzle:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bde5d47 on pkasperowicz:Custom_Filter_Header_Height into ** on adazzle:master**.

@malonecj malonecj merged commit 49a51f8 into Comcast:master Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants