fix: add disposition type to Content-Disposition header (RFC 2183)#12497
Open
quantumnic wants to merge 1 commit intoComfy-Org:masterfrom
Open
fix: add disposition type to Content-Disposition header (RFC 2183)#12497quantumnic wants to merge 1 commit intoComfy-Org:masterfrom
quantumnic wants to merge 1 commit intoComfy-Org:masterfrom
Conversation
The Content-Disposition header was set to 'filename="name.ext"' without a disposition type, violating RFC 2183. This caused third-party HTTP clients (e.g. Go's mime.ParseMediaType) to fail parsing the filename. Added 'inline;' disposition type prefix to all Content-Disposition headers in the /view endpoint. Fixes Comfy-Org#8914
quantumnic
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Member
Test Evidence CheckIf this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions. If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8914
The
Content-Dispositionheader in the/viewendpoint was set tofilename="name.ext"without a disposition type, violating RFC 2183.This caused third-party HTTP clients (e.g. Go's
mime.ParseMediaType) to fail parsing the filename from the header, leading to downloaded files being namedviewinstead of the correct filename.Changes
Added
inline;disposition type prefix to all fourContent-Dispositionheaders inserver.py:inlineis used (rather thanattachment) to preserve the current browser behavior of displaying content directly rather than triggering a download dialog.