fix: change SaveAnimatedWEBP default method to 'fastest' for better performance#13334
Conversation
…t' (fixes Comfy-Org#13300) The 'default' compression method maps to WebP method=4, which is significantly slower than method=0 ('fastest'). For animated WebP with many frames (e.g. 120 frames of video), this resulted in encoding times of 2+ minutes. Changing the node default to 'fastest' (method=0) reduces encoding time by ~3x while still allowing users to select higher compression methods when needed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #13300
Problem
The
SaveAnimatedWEBPnode defaults tomethod='default'which maps to WebP compression method=4. This causes very slow encoding times for animated WebP files with many frames — users reported 2.5+ minutes for 120-frame videos.Community testing confirmed that switching to
method='fastest'(method=0) reduces encoding time from ~31s to ~10s for typical use cases.Solution
Change the default value for the
methodcombo input from'default'(method=4) to'fastest'(method=0).All options (
default,fastest,slowest) remain available for users who need higher compression ratios. This only changes what is selected when a user first adds the node to their workflow.Testing
COMPRESS_METHODS = {"default": 4, "fastest": 0, "slowest": 6}mapping is unchangeddefault="fastest"parameter is correctly handled byIO.Combo.Input