Skip to content

fix: SDPose - resize input always#13349

Merged
Kosinkadink merged 2 commits intoComfy-Org:masterfrom
kijai:sdpose_fixes
Apr 10, 2026
Merged

fix: SDPose - resize input always#13349
Kosinkadink merged 2 commits intoComfy-Org:masterfrom
kijai:sdpose_fixes

Conversation

@kijai
Copy link
Copy Markdown
Contributor

@kijai kijai commented Apr 10, 2026

The model can't handle too large images, so it should force resize the input always, currently it's only done when using bboxes. Also fixed small error in the heatmap postprocessing, to make it match the original cv2 method better, and added batching to RT-DETR as it would OOM on huge amount of input frames.

And also added support for the intermediate dtype on the pose drawing node.

Issue brought up by a user here:
#12661 (comment)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

📝 Walkthrough

Walkthrough

Three modules received refinements to pose estimation and detection inference. In the Gaussian blur operation of pose heatmap processing, the truncation parameter was explicitly set to 2.5. In RT-DETR detection inference, execution was restructured to process batches in 32-item sub-batches instead of processing the entire input at once. In SDPose keypoint extraction, device and dtype handling was added, two helper functions were introduced for image resizing and keypoint coordinate remapping, and VAE encoding calls were refactored to work with resized images across different processing modes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: forcing SDPose to always resize input, which is the primary modification across the changed files.
Description check ✅ Passed The pull request description clearly explains the changes: force-resizing inputs for SDPose, fixing heatmap postprocessing, adding RT-DETR batching, and supporting intermediate dtype in the pose drawing node.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kosinkadink Kosinkadink merged commit a134423 into Comfy-Org:master Apr 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants