Skip to content

Update quant doc so it's not completely wrong.#13381

Merged
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1
Apr 13, 2026
Merged

Update quant doc so it's not completely wrong.#13381
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

There is still more that needs to be fixed.

There is still more that needs to be fixed.
@comfyanonymous comfyanonymous merged commit 9719323 into master Apr 13, 2026
15 of 16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch April 13, 2026 03:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This pull request updates the quantization metadata documentation in QUANTIZATION.md. The example JSON structure for _quantization_metadata.layers was modified to change how layer format information is represented. Previously, layer names mapped directly to format strings. Now, layer names map to objects containing a format field. Additionally, a trailing newline was added to the file. These are documentation-only changes with no impact on public exports.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title refers to updating quantization documentation, which matches the changeset's focus on correcting the quantization metadata JSON structure example.
Description check ✅ Passed The description acknowledges that more fixes are needed, which is related to the documentation update in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant