Fix SQLAlchemy version format in requirements.txt (CORE-105)#13547
Merged
comfyanonymous merged 3 commits intomasterfrom Apr 30, 2026
Merged
Fix SQLAlchemy version format in requirements.txt (CORE-105)#13547comfyanonymous merged 3 commits intomasterfrom
comfyanonymous merged 3 commits intomasterfrom
Conversation
Change SQLAlchemy>=2.0 to SQLAlchemy>=2.0.0 to satisfy the X.Y.Z version format expected by install_util.is_valid_version(). Amp-Thread-ID: https://ampcode.com/threads/T-019db845-71fe-7748-a867-d1245e82f284 Co-authored-by: Amp <amp@ampcode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe pull request updates the SQLAlchemy dependency specification in 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
SQLAlchemy>=2.0toSQLAlchemy>=2.0.0to match the X.Y.Z format expected byinstall_util.is_valid_version().The custom version parser in
utils/install_util.pyuses a strict^(\d+)\.(\d+)\.(\d+)$regex, so the 2-part2.0fails validation and emits a debug log:Invalid version format in requirements.txt: 2.0. Using the 3-part2.0.0fixes this while preserving the minimum version constraint (needed forDeclarativeBase,Mapped,mapped_column, etc.).Closes the issue raised in #13525.