Skip to content

Fix SQLAlchemy version format in requirements.txt (CORE-105)#13547

Merged
comfyanonymous merged 3 commits intomasterfrom
fix/sqlalchemy-version-format
Apr 30, 2026
Merged

Fix SQLAlchemy version format in requirements.txt (CORE-105)#13547
comfyanonymous merged 3 commits intomasterfrom
fix/sqlalchemy-version-format

Conversation

@Kosinkadink
Copy link
Copy Markdown
Member

Change SQLAlchemy>=2.0 to SQLAlchemy>=2.0.0 to match the X.Y.Z format expected by install_util.is_valid_version().

The custom version parser in utils/install_util.py uses a strict ^(\d+)\.(\d+)\.(\d+)$ regex, so the 2-part 2.0 fails validation and emits a debug log: Invalid version format in requirements.txt: 2.0. Using the 3-part 2.0.0 fixes this while preserving the minimum version constraint (needed for DeclarativeBase, Mapped, mapped_column, etc.).

Closes the issue raised in #13525.

Change SQLAlchemy>=2.0 to SQLAlchemy>=2.0.0 to satisfy the X.Y.Z
version format expected by install_util.is_valid_version().

Amp-Thread-ID: https://ampcode.com/threads/T-019db845-71fe-7748-a867-d1245e82f284
Co-authored-by: Amp <amp@ampcode.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d2600c04-abfe-4fe8-b105-248f6ab4a96a

📥 Commits

Reviewing files that changed from the base of the PR and between 57dfad1 and 7d34982.

📒 Files selected for processing (1)
  • requirements.txt
✅ Files skipped from review due to trivial changes (1)
  • requirements.txt

📝 Walkthrough

Walkthrough

The pull request updates the SQLAlchemy dependency specification in requirements.txt from >=2.0 to >=2.0.0. This is a single-line change in requirements.txt; no other dependencies, files, or application logic were modified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the SQLAlchemy version format in requirements.txt from a 2-part to 3-part version specifier.
Description check ✅ Passed The description provides clear context about the change, explaining why the format adjustment is necessary (to match the X.Y.Z regex validation) and what it preserves (minimum version constraint).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexisrolland alexisrolland changed the title Fix SQLAlchemy version format in requirements.txt Fix SQLAlchemy version format in requirements.txt (CORE-98) Apr 27, 2026
@alexisrolland alexisrolland changed the title Fix SQLAlchemy version format in requirements.txt (CORE-98) Fix SQLAlchemy version format in requirements.txt (CORE-105) Apr 27, 2026
@comfyanonymous comfyanonymous merged commit a7d82ba into master Apr 30, 2026
21 checks passed
@comfyanonymous comfyanonymous deleted the fix/sqlalchemy-version-format branch April 30, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants