Skip to content

Make EmptySD3LatentImage node use intermediate dtype.#13577

Merged
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1
Apr 27, 2026
Merged

Make EmptySD3LatentImage node use intermediate dtype.#13577
comfyanonymous merged 1 commit intomasterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca4140a8-d0af-4a59-974f-4e61704891e5

📥 Commits

Reviewing files that changed from the base of the PR and between 7385eb2 and 67ece5f.

📒 Files selected for processing (1)
  • comfy_extras/nodes_sd3.py

📝 Walkthrough

Walkthrough

The SD3 latent image node's execute method has been updated to explicitly specify the tensor data type when creating a zero latent tensor. The change introduces calls to comfy.model_management.intermediate_dtype() and comfy.model_management.intermediate_device() to determine the appropriate precision and device for the allocation. The shape and device assignment behavior remain unchanged; only the tensor's data type specification differs from the previous implementation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, but the title alone conveys the intent and the change is straightforward enough to be understood. Consider adding a brief description explaining why intermediate dtype is needed (e.g., dtype consistency, memory efficiency) for better context.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating EmptySD3LatentImage node to use intermediate dtype for tensor allocation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit 115f418 into master Apr 27, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch April 27, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant