Skip to content

Update CODEOWNERS to add permissions to teams#13649

Open
alexisrolland wants to merge 9 commits intomasterfrom
alexis/codeowners
Open

Update CODEOWNERS to add permissions to teams#13649
alexisrolland wants to merge 9 commits intomasterfrom
alexis/codeowners

Conversation

@alexisrolland
Copy link
Copy Markdown
Member

Granting the following permissions:

  • Merge permission to @Comfy-Org/partner-nodes-mergers on /comfy_api_nodes/.
  • Merge permission to @Comfy-Org/frontend-team on /requirements.txt to allow them to update comfyui-frontend-package version.
  • Merge permission to @Comfy-Org/gtm-team on /requirements.txt to allow them to update comfyui-workflow-templates and comfyui-embedded-docs versions.

With great powers come great responsibilities. Use those permissions wisely.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated CODEOWNERS to add an ownership mapping for /comfy_api_nodes/ to partner-nodes-mergers, and extended ownership for requirements.txt by adding frontend-team and gtm-team. Seven lines were added and no lines removed. The CODEOWNERS file does not end with a trailing newline.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating CODEOWNERS to grant permissions to teams, which matches the changeset exactly.
Description check ✅ Passed The description is directly related to the changeset, detailing the specific team permissions being granted for different file paths in the CODEOWNERS update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CODEOWNERS`:
- Around line 7-11: The CODEOWNERS file contains two duplicate rules for the
same path `/requirements.txt` which causes only the last entry to take effect;
update the CODEOWNERS content by consolidating the two entries into a single
rule for `/requirements.txt` and list both owners (e.g., include both
`@frontend-team` and `@gtm-team` on the same line) so both teams are assigned as
code owners for that file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 56503e46-3132-4ebf-b781-5c7938d8d346

📥 Commits

Reviewing files that changed from the base of the PR and between 97f58ba and 96bfd2f.

📒 Files selected for processing (1)
  • CODEOWNERS

Comment thread CODEOWNERS Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants