Skip to content

chore(api-nodes): increase default timeout for partner API node tasks#13663

Merged
Kosinkadink merged 2 commits intomasterfrom
chore/api-nodes/increase-polling-timeout
May 1, 2026
Merged

chore(api-nodes): increase default timeout for partner API node tasks#13663
Kosinkadink merged 2 commits intomasterfrom
chore/api-nodes/increase-polling-timeout

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented May 1, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

📝 Walkthrough

Walkthrough

This pull request consolidates polling timeout configuration across video and image generation API integrations. The core polling functions in util/client.py increase their default max_poll_attempts parameter from 160 to 480. Correspondingly, explicit max_poll_attempts overrides are removed from individual node implementations across multiple providers (ByteDance, HitPaw, Kling, Magnific, Topaz, ViDu, Wan, and WaveSpeed), allowing them to inherit the new default. The ViDu module also updates its internal execute_task helper default from 320 to 480.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description provided is a template checklist with minimal actual content. It does not describe the changeset or explain why the polling timeout is being increased. Add a meaningful description explaining the rationale for increasing the default polling timeout from 160 to 480, and clarify which API nodes are affected by this change.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: increasing default timeout for partner API node tasks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kosinkadink Kosinkadink merged commit cf758bd into master May 1, 2026
22 checks passed
@bigcat88 bigcat88 deleted the chore/api-nodes/increase-polling-timeout branch May 1, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants