Skip to content

PrimitiveInt: default control_after_generate widget to fixed (CORE-141)#13690

Merged
alexisrolland merged 1 commit intomasterfrom
primitive-int-control-after-generate-fixed
May 3, 2026
Merged

PrimitiveInt: default control_after_generate widget to fixed (CORE-141)#13690
alexisrolland merged 1 commit intomasterfrom
primitive-int-control-after-generate-fixed

Conversation

@Kosinkadink
Copy link
Copy Markdown
Member

Sets the control_after_generate widget on the PrimitiveInt node to default to fixed instead of the previous default (randomize).

Uses the io.ControlAfterGenerate.fixed enum value, which is already supported by Int.Input (typed as bool | ControlAfterGenerate).

The ControlAfterGenerate enum exposes fixed, increment, decrement, and randomize — passing True previously left the default behavior up to the frontend (randomize). For a generic int primitive, fixed is the saner default since most integer values aren't seed-like.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9a840168-bfe6-4004-9bfd-ff7312b89110

📥 Commits

Reviewing files that changed from the base of the PR and between cea8d09 and 7092312.

📒 Files selected for processing (1)
  • comfy_extras/nodes_primitive.py

📝 Walkthrough

Walkthrough

The Int node schema configuration in comfy_extras/nodes_primitive.py was updated to use an enumerated control type instead of a boolean value. The control_after_generate parameter in the io.Int.Input() method now specifies io.ControlAfterGenerate.fixed instead of True. This single-line change modifies how the node's value control behaves following generation, with no other modifications to node schemas or execution logic.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating the PrimitiveInt node's control_after_generate widget default from randomize to fixed.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for defaulting control_after_generate to fixed and providing context about the ControlAfterGenerate enum.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@alexisrolland alexisrolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses the discussion on #10347

@alexisrolland alexisrolland merged commit 2806163 into master May 3, 2026
27 checks passed
@alexisrolland alexisrolland changed the title PrimitiveInt: default control_after_generate widget to fixed PrimitiveInt: default control_after_generate widget to fixed (CORE-141) May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants