PrimitiveInt: default control_after_generate widget to fixed (CORE-141)#13690
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019def7f-a638-72fc-a69c-017c8db2c323 Co-authored-by: Amp <amp@ampcode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
alexisrolland
left a comment
There was a problem hiding this comment.
Addresses the discussion on #10347
Sets the
control_after_generatewidget on thePrimitiveIntnode to default tofixedinstead of the previous default (randomize).Uses the
io.ControlAfterGenerate.fixedenum value, which is already supported byInt.Input(typed asbool | ControlAfterGenerate).The
ControlAfterGenerateenum exposesfixed,increment,decrement, andrandomize— passingTruepreviously left the default behavior up to the frontend (randomize). For a generic int primitive,fixedis the saner default since most integer values aren't seed-like.