Skip to content

Add temporal_downscale_ratio to LatentFormat (CORE-147)#13702

Merged
Kosinkadink merged 4 commits intoComfy-Org:masterfrom
drozbay:20260503a_temporal_downscale_ratio
May 5, 2026
Merged

Add temporal_downscale_ratio to LatentFormat (CORE-147)#13702
Kosinkadink merged 4 commits intoComfy-Org:masterfrom
drozbay:20260503a_temporal_downscale_ratio

Conversation

@drozbay
Copy link
Copy Markdown
Contributor

@drozbay drozbay commented May 4, 2026

Symmetric counterpart to the existing LatentFormat.spacial_downscale_ratio. Default 1, overridden on video formats with their VAE temporal factor (Mochi 6, LTXV 8, HunyuanVideo / HunyuanVideo15 / Wan21 / CogVideoX 4, Cosmos1CV8x8x8 8; LTXAV and Wan22 inherit). Each value verified against the corresponding VAE's upscale_index_formula in comfy/sd.py.

Metadata-only, no behavior change. Lets code that has a model but no VAE in scope read model.model.latent_format.temporal_downscale_ratio directly, mirroring how spacial_downscale_ratio is already used at comfy/sample.py:48-49.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c44ae3cb-5c06-4921-b7df-9fb9115f38f1

📥 Commits

Reviewing files that changed from the base of the PR and between f3ea976 and 8b2b2b0.

📒 Files selected for processing (1)
  • comfy/latent_formats.py

📝 Walkthrough

Walkthrough

The change introduces a temporal_downscale_ratio class attribute to the latent format classes. A base value of 1 is defined on the LatentFormat class, and this attribute is overridden with format-specific values in seven video-capable latent format implementations. The values assigned range from 4 to 8 depending on the format, with most video formats using either 4 or 8.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a temporal_downscale_ratio attribute to LatentFormat with a reference to the issue (CORE-147).
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose, default values, and specific overrides for each video format class, as well as the verification methodology.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kosinkadink Kosinkadink merged commit 1655f80 into Comfy-Org:master May 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants