Skip to content

chore: Update display names and categories for text nodes (CORE-155)#13712

Merged
alexisrolland merged 4 commits intomasterfrom
alexis/text-nodes-naming-cleanup
May 5, 2026
Merged

chore: Update display names and categories for text nodes (CORE-155)#13712
alexisrolland merged 4 commits intomasterfrom
alexis/text-nodes-naming-cleanup

Conversation

@alexisrolland
Copy link
Copy Markdown
Member

Second pass of clean-up on native nodes display names and categories (first pass here: #13693).

Loosely following the dominant pattern

  • Node Id CamelCase → spaces
  • Verb first
  • Add missing search aliases
  • Focus on text category
    • Promoted utils/text category to root text category

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 459dd6b4-bdc8-4314-99b7-df4b124c091d

📥 Commits

Reviewing files that changed from the base of the PR and between b933a4d and cb230b5.

📒 Files selected for processing (1)
  • comfy_extras/nodes_string.py
✅ Files skipped from review due to trivial changes (1)
  • comfy_extras/nodes_string.py

📝 Walkthrough

Walkthrough

This pull request updates schema metadata for string-related nodes in two files. In comfy_extras/nodes_primitive.py, String and StringMultiline schemas change display_name to "Text String" and "Text String (Multiline)" and add search_aliases. In comfy_extras/nodes_string.py, a set of string utility nodes have adjusted display_name values, standardized category to "text", and revised search_aliases. There are no changes to node I/O, execution logic, or registration.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating display names and categories for text nodes, which matches the file summaries.
Description check ✅ Passed The description is directly related to the changeset, explaining the cleanup pattern and goals (display names, categories, search aliases for text nodes).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_extras/nodes_string.py`:
- Line 347: The search_aliases list contains a duplicate entry "regex replace";
open the definition of search_aliases in comfy_extras/nodes_string.py (the
search_aliases array) and remove the duplicated "regex replace" entry so each
alias appears only once, preserving the other aliases like "regex", "pattern
replace", and "substitution".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2ff46ce7-72bf-43a8-822e-5fee7e46e780

📥 Commits

Reviewing files that changed from the base of the PR and between fed8d5e and b933a4d.

📒 Files selected for processing (2)
  • comfy_extras/nodes_primitive.py
  • comfy_extras/nodes_string.py

Comment thread comfy_extras/nodes_string.py Outdated
rattus128
rattus128 previously approved these changes May 5, 2026
Copy link
Copy Markdown
Contributor

@rattus128 rattus128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one small correction that rabbit found for me.

Comment thread comfy_extras/nodes_string.py Outdated
@alexisrolland
Copy link
Copy Markdown
Member Author

"Regex Replace"

Thanks fixed!

@alexisrolland alexisrolland merged commit 639f631 into master May 5, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants