Skip to content

chore: Various QoL updates of nodes display names, descriptions and categories (CORE-190, CORE-191)#13830

Merged
comfyanonymous merged 23 commits into
masterfrom
alexis/nodes-categories-and-names
May 19, 2026
Merged

chore: Various QoL updates of nodes display names, descriptions and categories (CORE-190, CORE-191)#13830
comfyanonymous merged 23 commits into
masterfrom
alexis/nodes-categories-and-names

Conversation

@alexisrolland
Copy link
Copy Markdown
Member

@alexisrolland alexisrolland commented May 11, 2026

This pull request reorganizes the categorization of several nodes to improve clarity and consistency in the contextual menu. The main changes involve moving nodes from subcategories to more general categories, and updating display names for clarity.

Category reorganization for samplers, schedulers, and sigmas:

  • Changed the category field for all sampler nodes (e.g., SamplerLCMUpscale, SamplerARVideo, and multiple classes in nodes_custom_sampler.py) from sampling/custom_sampling/samplers to sampling/samplers for better organization and discoverability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]
  • Changed the category field for all scheduler nodes (e.g., AlignYourStepsScheduler, BasicScheduler, KarrasScheduler, etc.) from sampling/custom_sampling/schedulers to sampling/schedulers. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Updated the category for all sigma-related nodes from sampling/custom_sampling/sigmas to sampling/sigmas for consistency. [1] [2] [3] [4] [5] [6]

Image processing node improvements:

  • Renamed category image/preprocessors and image/postprocessors to group them into a single category image/filters.
  • Changed the category of the Canny node from image/preprocessors to image/filters, and updated its display_name from "Canny" to "Detect Canny Edges" for improved clarity and user searchability.

Mask category

  • Moved mask category under image category since mask are always used in combination with images.

Save Image Nodes

  • Moved Save Animated WEBP and Save Animated PNG nodes to the root of the image category, for consistency with other save nodes.

These changes help standardize node organization, making it easier for users and developers to find and maintain nodes in the codebase.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates only node UI schema metadata across many files: nodes are moved from custom or generic groups (e.g., sampling/custom_sampling/*, mask, detection, image/postprocessing) into standardized categories (sampling/schedulers, sampling/samplers, sampling/guiders, sampling/sigmas, sampling/noise, image/filters, image/mask, image/detection, image, training/dataset). Several nodes received or had display_name or DESCRIPTION strings adjusted. No execution logic, public signatures, algorithms, or exported node lists were modified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the PR's main objective of reorganizing node categories and updating display names/descriptions for improved UX.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, explaining the category reorganizations, display name updates, and improvements to node organization.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_extras/nodes_mask.py`:
- Around line 198-200: The node schema was renamed by changing node_id from
"SolidMask" to "CreateSolidMask", which breaks backward compatibility; restore
node_id to "SolidMask" and keep the new UI label by setting display_name="Create
Solid Mask" while leaving node_id="SolidMask" unchanged (update wherever the
node is defined—look for the schema that currently lists
node_id="CreateSolidMask" and display_name="Create Solid Mask" and swap to
node_id="SolidMask" with display_name="Create Solid Mask").
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0b324eb1-e241-47c2-a29f-a76f899473b4

📥 Commits

Reviewing files that changed from the base of the PR and between dabfe73 and 9479c1e.

📒 Files selected for processing (20)
  • comfy_extras/nodes_advanced_samplers.py
  • comfy_extras/nodes_align_your_steps.py
  • comfy_extras/nodes_ar_video.py
  • comfy_extras/nodes_canny.py
  • comfy_extras/nodes_custom_sampler.py
  • comfy_extras/nodes_flux.py
  • comfy_extras/nodes_gits.py
  • comfy_extras/nodes_images.py
  • comfy_extras/nodes_lt.py
  • comfy_extras/nodes_mask.py
  • comfy_extras/nodes_morphology.py
  • comfy_extras/nodes_nop.py
  • comfy_extras/nodes_optimalsteps.py
  • comfy_extras/nodes_post_processing.py
  • comfy_extras/nodes_rtdetr.py
  • comfy_extras/nodes_sam3.py
  • comfy_extras/nodes_sdpose.py
  • comfy_extras/nodes_video_model.py
  • comfy_extras/nodes_void.py
  • nodes.py

Comment thread comfy_extras/nodes_mask.py Outdated
@alexisrolland alexisrolland changed the title chore: Various QoL updates of nodes display names, descriptions and categories chore: Various QoL updates of nodes display names, descriptions and categories (CORE-190) May 11, 2026
@alexisrolland alexisrolland changed the title chore: Various QoL updates of nodes display names, descriptions and categories (CORE-190) chore: Various QoL updates of nodes display names, descriptions and categories (CORE-190, CORE-191) May 11, 2026
@drozbay
Copy link
Copy Markdown
Contributor

drozbay commented May 11, 2026

Awesome stuff! Just want to note that it's very hard to test any of this because the actual display names on the frontend follow the frontend repo's locale names, even for English. They won't change until the frontend repo is updated after this is merged.
image

@alexisrolland
Copy link
Copy Markdown
Member Author

@drozbay you're correct, I noticed this while doing my tests as well. The frontend has an automated process to localize nodes names so that's why they're not immediately visible when testing. I don't have a better option right now. I am just using this command line to recheck once in a while before frontend gets updated in stable: python main.py --front-end-version Comfy-Org/ComfyUI_frontend@latest --enable-manager

Comment thread comfy_extras/nodes_canny.py Outdated
Comment thread comfy_extras/nodes_dataset.py Outdated
Comment thread comfy_extras/nodes_nop.py Outdated
@comfyanonymous comfyanonymous merged commit d71cc1c into master May 19, 2026
21 checks passed
@comfyanonymous comfyanonymous deleted the alexis/nodes-categories-and-names branch May 19, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants