Skip to content

Revert "Include workflow_id in all execution WebSocket messages (CORE-198)"#13901

Merged
comfyanonymous merged 1 commit into
masterfrom
revert-13684-glary/ws-workflow-id
May 14, 2026
Merged

Revert "Include workflow_id in all execution WebSocket messages (CORE-198)"#13901
comfyanonymous merged 1 commit into
masterfrom
revert-13684-glary/ws-workflow-id

Conversation

@comfyanonymous
Copy link
Copy Markdown
Member

Reverts #13684

@linear
Copy link
Copy Markdown

linear Bot commented May 14, 2026

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 63645e0f-2826-4abe-b4ae-d49e4500872e

📥 Commits

Reviewing files that changed from the base of the PR and between 4f60189 and 076d6c5.

📒 Files selected for processing (7)
  • comfy_execution/jobs.py
  • comfy_execution/progress.py
  • execution.py
  • main.py
  • server.py
  • tests-unit/execution_test/test_workflow_id_in_ws_messages.py
  • tests/execution/test_jobs.py
💤 Files with no reviewable changes (2)
  • tests-unit/execution_test/test_workflow_id_in_ws_messages.py
  • tests/execution/test_jobs.py

📝 Walkthrough

Walkthrough

This pull request removes workflow_id from execution infrastructure and client-facing WebSocket events. The changes eliminate the workflow_id parameter from execution function signatures (execute() and _send_cached_ui()), simplify progress tracking by removing it from ProgressRegistry and reset_progress_state(), strip it from all emitted WebSocket payloads (executing, executed, execution_cached, execution_error, execution_success), and remove its extraction and propagation from the main prompt worker entry point. Supporting changes inline job metadata extraction and simplify server reconnection event payloads accordingly.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reverting a previous PR that added workflow_id to WebSocket messages.
Description check ✅ Passed The description is directly related to the changeset—it identifies the specific PR being reverted (#13684).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@comfyanonymous comfyanonymous merged commit 616cab4 into master May 14, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the revert-13684-glary/ws-workflow-id branch May 14, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant