Skip to content

chore: correct OOM memory summary format#13950

Merged
alexisrolland merged 1 commit into
Comfy-Org:masterfrom
Apophis3158:oom-summary-format
May 18, 2026
Merged

chore: correct OOM memory summary format#13950
alexisrolland merged 1 commit into
Comfy-Org:masterfrom
Apophis3158:oom-summary-format

Conversation

@Apophis3158
Copy link
Copy Markdown
Contributor

The current OOM memory summary's header format is skewed:

Memory summary: |===========================================================================|
|                  PyTorch CUDA memory summary, device ID 0                 |
|---------------------------------------------------------------------------|
|            CUDA OOMs: 0            |        cudaMalloc retries: 0         |
|===========================================================================|
|        Metric         | Cur Usage  | Peak Usage | Tot Alloc  | Tot Freed  |
|---------------------------------------------------------------------------|

Add a return:

Memory summary:
|===========================================================================|
|                  PyTorch CUDA memory summary, device ID 0                 |
|---------------------------------------------------------------------------|
|            CUDA OOMs: 0            |        cudaMalloc retries: 0         |
|===========================================================================|
|        Metric         | Cur Usage  | Peak Usage | Tot Alloc  | Tot Freed  |
|---------------------------------------------------------------------------|

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d8117ead-2533-41bd-915c-86e6ff8d6b14

📥 Commits

Reviewing files that changed from the base of the PR and between f48d2a0 and 9576d13.

📒 Files selected for processing (1)
  • execution.py

📝 Walkthrough

Walkthrough

This PR adjusts the GPU OOM exception handler logging in execution.py to format the memory summary output on multiple lines. The "Memory summary:" label is now separated from the detailed memory information by a newline character, changing from an inline format to multi-line display. This is a single-line modification to the logging output.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: correct OOM memory summary format' clearly and specifically describes the main change—fixing the formatting of the OOM memory summary header.
Description check ✅ Passed The description is directly related to the changeset, providing clear before/after examples that illustrate the formatting issue being fixed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexisrolland alexisrolland merged commit aeadb7a into Comfy-Org:master May 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants